Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add featureDetectOverride configration of calico #9249

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Add featureDetectOverride configration of calico #9249

merged 1 commit into from
Sep 2, 2022

Conversation

lou-lan
Copy link
Contributor

@lou-lan lou-lan commented Sep 2, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8992

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2022
floryut
floryut approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lou-lan Thank you for the added feature
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 2, 2022
@yankay
Copy link
Member

yankay commented Sep 2, 2022 •
edited
Loading

/ok-to-test
/lgtm

it's an important config to solve the issue.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, lou-lan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2022
@yankay
Copy link
Member

yankay commented Sep 2, 2022 •
edited
Loading

Discussion:

Recommand to the set the defaul value calico_feature_detect_override: "ChecksumOffloadBroken=true" to Fixes #8992.

The solution is used by:

So, I suggest setting the default value to the ChecksumOffloadBroken=true, to disable the VLAN offload by default, so the calico can be worked in most cases.

And if the user wants to use VLAN offload, he can change the configuration.

@yankay
Copy link
Member

yankay commented Sep 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 133a7a0 into kubernetes-sigs:master Sep 2, 2022
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@lou-lan @enneitex
Add featureDetectOverride configration of calico (kubernetes-sigs#9249)
72f3080
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@lou-lan @nolimitkun
Add featureDetectOverride configration of calico (kubernetes-sigs#9249)
71d2c1d
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@lou-lan @LuckySB
Add featureDetectOverride configration of calico (kubernetes-sigs#9249)
a38aa60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankay yankay yankay left review comments

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VXLAN: bad UDP checksums
4 participants
@lou-lan @yankay @k8s-ci-robot @floryut